Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group creation #374

Merged
merged 11 commits into from
Apr 27, 2024
Merged

Group creation #374

merged 11 commits into from
Apr 27, 2024

Conversation

BramMeir
Copy link
Contributor

closes #373
closes #344

Group creation when creating a project is refactored as follows:

  • If the project is individual (group size set to 1), a group is created for each user, with the user automatically assigned to this group.
  • Otherwise the teacher can specify the number of groups, creating that number of empty groups.
  • If no number of groups is passed in the form field, the default number of groups created is the number of students in the course divided by the group size.

If a new student joins the course when there are already projects:

  • If there are individual projects, a new group is created for that user.
  • If there are now projects with more students than places in the groups, a new group is created.

If anyone has a better strategy, let me know.

@BramMeir BramMeir added frontend Issues regarding the frontend backend labels Apr 27, 2024
@BramMeir BramMeir added this to the Final milestone milestone Apr 27, 2024
@BramMeir BramMeir self-assigned this Apr 27, 2024
Topvennie
Topvennie approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@EwoutV EwoutV merged commit 10df4a5 into development Apr 27, 2024
3 checks passed
@EwoutV EwoutV deleted the group-creation branch April 27, 2024 14:18
DeLany123 pushed a commit that referenced this pull request Apr 29, 2024
@BramMeir @DeLany123
Group creation (#374)
5a5ebda 
* chore: group size field

* fix: student added to individual projects when joining course after project creation

* fix: new group created when students join course and groups are full

* fix: delete from course button was displayed for students

* fix: do not remove teacher role when deleted from last course

* fix: linting

* fix: only show visible projects to students

* fix: still display for teachers

* fix: only creating groups when project is in future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Topvennie Topvennie Topvennie approved these changes

@EwoutV EwoutV Awaiting requested review from EwoutV

@francisvaut francisvaut Awaiting requested review from francisvaut

@bsilkyn bsilkyn Awaiting requested review from bsilkyn

Assignees

@BramMeir BramMeir

Labels
backend frontend Issues regarding the frontend
Projects
None yet
Milestone
Final milestone
Development

Successfully merging this pull request may close these issues.

Frontend: only display visible projects to students Backend: group creation for projects
3 participants
@BramMeir @Topvennie @EwoutV